feat: add check updates command #577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexng353
force-pushed
the
alex/check-updates
branch
from
b2f3436 to
dbe15b4
Compare
brody192
changed the title
alexng353
changed the title
coffee-cup
reviewed
Dec 9, 2024
| @@ -42,3 +42,22 @@ macro_rules! interact_or { | |||
| } | |||
| }; | |||
| } | |||
|
|
|||
| #[macro_export] | |||
| macro_rules! check_update { | |||
There was a problem hiding this comment.
Why does this have to be a macro instead of just a function? In general I'd prefer to avoid macros unless absolutely necessary.
There was a problem hiding this comment.
It's a macro because I can overload the call signature of it to default the second parameter to false, but I can make it into a function if you want.
There was a problem hiding this comment.
I think a function is preferred here for simplicity. If you want to avoid having to provided false as the second parameter, we can have a check_update_command function that passed false
simplified check_updates command fix: more user-friendly error message for check_updates on Config write failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.